[lm-sensors] [PATCH] hwmon: (pmbus) More stringent checking of VOUT_MODE register

Guenter Roeck guenter.roeck at ericsson.com
Mon Mar 7 23:11:29 CET 2011


On Mon, Mar 07, 2011 at 04:44:43PM -0500, Greg Schnorr wrote:
> Looks good, tested and works on one such VOUT_MODE poor design...
> 
> On 3/1/11 9:32 PM, "Guenter Roeck" <guenter.roeck at ericsson.com> wrote:
> 
> > Some PMBus chips do not support the VOUT_MODE register. To make matters worse,
> > such chips may not return an error when reading the register either, but
> > instead
> > return 0xff.
> > 
> > Check if the register exists using pmbus_check_byte_register() before reading
> > its value. In addition, validate the returned value and ignore it if it is
> > 0xff
> > (which is invalid).
> > 
> > Reported-by: Greg Schnorr <gschnorr at cisco.com>
> > Signed-off-by: Guenter Roeck <guenter.roeck at ericsson.com>
> Acked-by: Greg Schnorr <gschnorr at cisco.com>
> 
Thanks!

Guenter




More information about the lm-sensors mailing list