[lm-sensors] [RFC 1/2] add new hwmon-core interface v2

Guenter Roeck guenter.roeck at ericsson.com
Thu Sep 15 22:57:28 CEST 2011


Hi Lucas,

On Thu, 2011-09-15 at 16:45 -0400, Lucas Stach wrote:
> Hello Guenter and others,
> 
> I reworked my first proposal of the hwmon-core API and would like to get
> some feedback.
> 
> After switching to a table based approach, as suggested by Jonathan
> Cameron, the actual code is pretty minimal, most of the code are
> definitions on how the sysfs has to look like and enums for the
> interface. It got a lot cleaner and maintainable this way.
> 
> All in all it's about 800 LOC and should enable a noticeable reduction
> in code size for drivers using it; quantity could be named after porting
> the first drivers.
> 
> Please review and give some feedback if you find the time. I want to
> bring this forward and port over the adt7475 driver, but first I have to
> know if you think the new API has a chance to take off. In a second mail
> you will find some stupid dummy driver which shows how to use the new
> API.
> 
Approach seems much better then before. However, checkpatch reports:

total: 132 errors, 80 warnings, 1004 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
      scripts/cleanfile

Please clean up and resubmit; with that many style errors, it is
difficult, at least for me, to read the code, much less to find the real
problems.

Thanks,
Guenter






More information about the lm-sensors mailing list