[lm-sensors] [PATCH] coretemp: remove struct platform_data * parameter from create_core_data()

Guenter Roeck guenter.roeck at ericsson.com
Fri Sep 23 19:45:41 CEST 2011


On Fri, 2011-09-23 at 06:40 -0400, Jan Beulich wrote:
> The only caller of the function obtained the pointer solely for the
> purpose of passing it to this function, while it can be easily
> determined from the struct platform_device * parameter also passed.
> 
> Signed-off-by: Jan Beulich <jbeulich at suse.com>
> 
> ---
>  drivers/hwmon/coretemp.c |    9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> --- 3.1-rc7-coretemp.orig/drivers/hwmon/coretemp.c
> +++ 3.1-rc7-coretemp/drivers/hwmon/coretemp.c
> @@ -548,11 +548,11 @@ static struct temp_data *init_temp_data(
>  	return tdata;
>  }
>  
> -static int create_core_data(struct platform_data *pdata,
> -				struct platform_device *pdev,
> +static int create_core_data(struct platform_device *pdev,
>  				unsigned int cpu, int pkg_flag)
>  {
>  	struct temp_data *tdata;
> +	struct platform_data *pdata = platform_get_drvdata(pdev);
>  	struct cpuinfo_x86 *c = &cpu_data(cpu);
>  	u32 eax, edx;
>  	int err, attr_no;
> @@ -625,16 +625,13 @@ exit_free:
>  
>  static void coretemp_add_core(unsigned int cpu, int pkg_flag)
>  {
> -	struct platform_data *pdata;
>  	struct platform_device *pdev = coretemp_get_pdev(cpu);
>  	int err;
>  
>  	if (!pdev)
>  		return;
>  
> -	pdata = platform_get_drvdata(pdev);
> -
> -	err = create_core_data(pdata, pdev, cpu, pkg_flag);
> +	err = create_core_data(pdev, cpu, pkg_flag);
>  	if (err)
>  		dev_err(&pdev->dev, "Adding Core %u failed\n", cpu);
>  }

Applied.

Thanks,
Guenter






More information about the lm-sensors mailing list