[lm-sensors] [PATCH] hwmon: (lm63) LM64 has a dedicated pin for tachometer

Guenter Roeck guenter.roeck at ericsson.com
Fri Jan 13 12:55:04 CET 2012


On Fri, Jan 13, 2012 at 04:13:21AM -0500, Jean Delvare wrote:
> On the LM64, the tachometer function has a dedicated pin and fan speed
> monitoring is always enabled.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>

> ---
>  Documentation/hwmon/lm63 |    4 +++-
>  drivers/hwmon/lm63.c     |    3 ++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> --- linux-3.3-rc0.orig/Documentation/hwmon/lm63	2012-01-13 09:09:25.000000000 +0100
> +++ linux-3.3-rc0/Documentation/hwmon/lm63	2012-01-13 09:54:38.000000000 +0100
> @@ -54,7 +54,9 @@ value for measuring the speed of the fan
>  Note that the pin used for fan monitoring is shared with an alert out
>  function. Depending on how the board designer wanted to use the chip, fan
>  speed monitoring will or will not be possible. The proper chip configuration
> -is left to the BIOS, and the driver will blindly trust it.
> +is left to the BIOS, and the driver will blindly trust it. Only the original
> +LM63 suffers from this limitation, the LM64 and LM96163 have separate pins
> +for fan monitoring and alert out.
>  
Maybe add a note here indicating that fan control is always enabled on LM64 only ?
Otherwise people may wonder why fans don't (always) show up on LM96163. 

Other than that,

Acked-by: Guenter Roeck <guenter.roeck at erisccon.com>

Thanks,
Guenter




More information about the lm-sensors mailing list