[lm-sensors] [PATCH 12/39] hwmon: (f71805f) Fix checkpatch issues

Guenter Roeck guenter.roeck at ericsson.com
Fri Jan 20 16:03:11 CET 2012


On Fri, Jan 20, 2012 at 08:33:46AM -0500, Jean Delvare wrote:
> On Mon, 16 Jan 2012 00:49:14 -0800, Guenter Roeck wrote:
> > Fixed:
> > ERROR: code indent should use tabs where possible
> > ERROR: do not use assignment in if condition
> > ERROR: "foo* bar" should be "foo *bar"
> > ERROR: need consistent spacing around '|' (ctx:VxW)
> > WARNING: simple_strtol is obsolete, use kstrtol instead
> > WARNING: simple_strtoul is obsolete, use kstrtoul instead
> > WARNING: static const char * array should probably be static const char * const
> > 
> > Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> > ---
> >  drivers/hwmon/f71805f.c |  163 ++++++++++++++++++++++++++++++++++-------------
> >  1 files changed, 118 insertions(+), 45 deletions(-)
> >
> > diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c
> > index 92f9497..859b203 100644
> > --- a/drivers/hwmon/f71805f.c
> > +++ b/drivers/hwmon/f71805f.c
> > (...)
> 
> Looks OK, tested without problems.
> 
> Acked-by: Jean Delvare <khali at linux-fr.org>
> 
> I noticed an unrelated bug during my testing, I'll investigate it and
> send a fix.
> 
Great .. a positive unintended side effect ;).

Thanks!
Guenter



More information about the lm-sensors mailing list