[lm-sensors] [PATCH 1/2] hwmon: (w83627ehf) Fix writing into fan_stop_time for NCT6775F/NCT6776F

Jean Delvare khali at linux-fr.org
Mon Mar 12 18:23:42 CET 2012


Hi Guenter,

On Mon, 12 Mar 2012 08:43:24 -0700, Guenter Roeck wrote:
> NCT6775F and NCT6776F have their own set of registers for FAN_STOP_TIME. The
> correct registers were used to read FAN_STOP_TIME, but writes used the wrong
> registers. Fix it.
> 
> Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> ---
>  drivers/hwmon/w83627ehf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 57a31a0..378142c 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1622,7 +1622,7 @@ store_##reg(struct device *dev, struct device_attribute *attr, \
>  	val = step_time_to_reg(val, data->pwm_mode[nr]); \
>  	mutex_lock(&data->update_lock); \
>  	data->reg[nr] = val; \
> -	w83627ehf_write_value(data, W83627EHF_REG_##REG[nr], val); \
> +	w83627ehf_write_value(data, data->REG_##REG[nr], val); \
>  	mutex_unlock(&data->update_lock); \
>  	return count; \
>  } \

Good catch.

Acked-by: Jean Delvare <khali at linux-fr.org>

This would seem like a candidate for stable, hm?

As a side note, someone's got to explain to me why these functions are
macro-generated when the macro is called only once. It would be a good
idea to unfold that code to make it easier to read.

-- 
Jean Delvare




More information about the lm-sensors mailing list