[lm-sensors] [PATCH] hwmon: (f75375s) Fix warning message seen in some configurations

[Jean Delvare]

Hi Guenter,

On Sat, 24 Mar 2012 08:45:07 -0700, Guenter Roeck wrote:
> In some configurations, BUG() does not result in an endless loop but returns to
> the caller. This results in the following compiler warning:
> 
> drivers/hwmon/f75375s.c: In function 'duty_mode_enabled':
> drivers/hwmon/f75375s.c:280: warning: control reaches end of non-void function
> drivers/hwmon/f75375s.c: In function 'auto_mode_enabled':
> drivers/hwmon/f75375s.c:295: warning: control reaches end of non-void function
> 
> Fix the warning by returning something sensible after BUG().
> 
> Cc: Nikolaus Schulz <schulz at macnetix.de>
> Cc: Riku Voipio <riku.voipio at iki.fi>
> Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> ---
>  drivers/hwmon/f75375s.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> index 729499e..ece4159 100644
> --- a/drivers/hwmon/f75375s.c
> +++ b/drivers/hwmon/f75375s.c
> @@ -276,6 +276,7 @@ static bool duty_mode_enabled(u8 pwm_enable)
>  		return false;
>  	default:
>  		BUG();
> +		return true;
>  	}
>  }
>  
> @@ -291,6 +292,7 @@ static bool auto_mode_enabled(u8 pwm_enable)
>  		return true;
>  	default:
>  		BUG();
> +		return false;
>  	}
>  }


Acked-by: Jean Delvare <khali at linux-fr.org>

-- 
Jean Delvare