[lm-sensors] [PATCH, v3] hwmon: coretemp: use list instead of fixed size array for temp data
durgadoss.r at intel.com
Mon May 7 13:17:57 CEST 2012
> > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > > index b9d5123..fa082d5 100644
> > > --- a/drivers/hwmon/coretemp.c
> > > +++ b/drivers/hwmon/coretemp.c
> > > @@ -36,6 +36,8 @@
> > > #include <linux/cpu.h>
> > > #include <linux/pci.h>
> > > #include <linux/smp.h>
> > > +#include <linux/list.h>
> > > +#include <linux/kref.h>
> > I think we don't need to include kref.h now :-)
> Right. :(
> Guenter, should I resend the patch or you can fix this on apply?
> > BTW, at some places, looks like we are using 'tdata' obtained from
> > without checking for NULL values. Other than that, looks Ok for me.
> Do you mean sysfs show methods? It should never be NULL there. If it's
> NULL, we have bug (race?) somewhere.
Yes agree with you. That's fine then.
> > Acked-by: Durgadoss R <durgadoss.r at intel.com>
You are welcome :-)
More information about the lm-sensors