[lm-sensors] Coretemp: Fix threshold attributes patch
durgadoss.r at intel.com
Wed May 9 18:53:09 CEST 2012
> > can discuss/decide and I can work on it to submit it again, with
> > changes needed,
> > if any. Kindly help.
> Hi Durga,
> problem is that neither Jean nor me are happy with it. I think it is
> something that should, by its nature, reside in the thermal subsystem.
I agree with you. If 'configuring the thresholds' were to reside in the Thermal
subsystem, then, one driver in hwmon will report CPU temperature and another
driver in thermal will configure the thresholds for that temperature. Is this
a good approach ?
Or, we can include the threshold configuration in coretemp under #ifdef
CONFIG_THERMAL. This way even though the code resides in hwmon,
the functionality is enabled only by the Thermal Subsystem.
Or, we can register coretemp with thermal_sys.c, and expose 2 trip points,
(for Threshold1 and Threshold2) like other thermal drivers do.
Let me know your thoughts.
More information about the lm-sensors