[lm-sensors] [PATCH v2] hwmon: (it87) Convert to use devm_kzalloc and devm_request_region
Guenter Roeck
guenter.roeck at ericsson.com
Sat May 12 17:43:03 CEST 2012
On Sat, May 12, 2012 at 11:39:51AM -0400, Jean Delvare wrote:
> On Fri, 11 May 2012 14:42:32 -0700, Guenter Roeck wrote:
> > From: Guenter Roeck <linux at roeck-us.net>
> >
> > This makes the code a bit simpler and smaller.
> >
> > Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> > ---
> > v2: Also convert devm_request_region for further simplification
> >
> > drivers/hwmon/it87.c | 32 +++++++++-----------------------
> > 1 files changed, 9 insertions(+), 23 deletions(-)
> > (...)
>
> Looks good.
>
> Acked-by: Jean Delvare <khali at linux-fr.org>
>
> It might make sense to rename ERROR4 to something more meaningful? With
> only this label remaining, the name looks obscure.
>
Makes sense. I'll do s/ERROR4/error/.
Thanks,
Guenter
More information about the lm-sensors
mailing list